[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229718. Tyker added a comment. Herald added a reviewer: deadalnix. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. fixe the issue causing buildbot failure. node were visited multiple time by the RecursiveASTVisitor in so

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

thakis added a comment. Reverted in c9276fbfdf0c7caf1576b2 for now. Please watch the bots after landing things, and revert if something breaks and it takes you a while to fix. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

sammccall added subscribers: ilya-biryukov, sammccall. sammccall added a comment. This seems to have broken clangd tests e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/58189/steps/test-check-all/logs/stdio FindExplicitReferences now finds duplicate refs

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ea1ee2db5f: [NFC] Refactor representation of materialized temporaries (authored by Tyker). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https:

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-tools-extra/clang-ti

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2642-2643 + if (S->getLifetimeExtendedTemporaryDecl()) +TRY_TO(TraverseLifetimeExtendedTemporaryDecl( +S->getLifetimeExtendedTemporaryDecl())); +}) rsmith wrote: >

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229242. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-tools-extra/clang-ti

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229240. Tyker marked 6 inline comments as done. Tyker added a comment. fixed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good subject to some comment fixes + a tiny change to `RecursiveASTVisitor`. Comment at: clang/include/clang/AST/DeclCXX.h:3055 +/// Implicit declartion of a

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added a comment. > 2. Change the constant expression representation for a pointer or reference > for a materialized temporary to refer to the temporary declaration instead. I analyzed change 2 in this list and this require changing a very significant number of users many of them being imp

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 227454. Tyker marked 8 inline comments as done. Tyker added a comment. fixed comments. i will do the other changes later. i also renamed MaterializeTemporaryExpr::GetTemporaryExpr to MaterializeTemporaryExpr::getSubExpr and change all uses of MaterializeTemp

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

rsmith added a comment. Thanks, I like this a lot. There are a few more changes we'll need in addition to this before we can properly serialize `APValue`s referring to such temporaries: 1. Merging during deserialization. For example, if we have inline int &&r = 123; in two different modules

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

martong added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/AST/ASTImporter.cpp:7004 + // FIXME: Should ManglingNumber get numbers associated with 'to' context? + auto* To = MaterializeTemporaryDecl::Create(Temporary, ExtendingDecl, +

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: shafik. Herald added a project: clang. this patch refactor representation of materialized temporaries to prevent an issue raised