Tyker added inline comments.
================ Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2642-2643 + if (S->getLifetimeExtendedTemporaryDecl()) + TRY_TO(TraverseLifetimeExtendedTemporaryDecl( + S->getLifetimeExtendedTemporaryDecl())); +}) ---------------- rsmith wrote: > ... and we should set `ShouldVisitChildren = false;` here because we already > visited the children when visiting the `LifetimeExtendedTemporaryDecl`. as far as i understanding, `LifetimeExtendedTemporaryDecl` is not listed in the childrens of `MaterializeTemporaryExpr`, it is not returned by `MaterializeTemporaryExpr::children` however the subexpression of `MaterializeTemporaryExpr` is listed in the children and need to be traversed. so i don't think this change is correct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
