thakis added a comment.
Reverted in r374503.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68832/new/
https://reviews.llvm.org/D68832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
thakis added a comment.
This fails on Mac and windows http://45.33.8.238/win/247/step_6.txt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68832/new/
https://reviews.llvm.org/D68832
___
cfe-commits mail
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5c72aa232e74: [tsan,msan] Insert module constructors in a
module pass (authored by vitalybuka).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68832/new/
htt
vitalybuka updated this revision to Diff 224501.
vitalybuka marked 2 inline comments as done.
vitalybuka added a comment.
nfc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68832/new/
https://reviews.llvm.org/D68832
Files:
clang/lib/CodeGen/Backe
leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.
Thanks for finding the root cause of this!
Comment at: llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp:143
+
+static void insertModuleCtor(Module &M) {
+ g
vitalybuka created this revision.
vitalybuka added reviewers: eugenis, leonardchan.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
If we insert them from function pass some analysis may be missing or invalid.
Fixes PR42877.
Repository:
rG LL
