[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

[Leonard Chan via Phabricator via cfe-commits]

leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.

Thanks for finding the root cause of this!



================
Comment at: llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp:143
+
+static void insertModuleCtor(Module &M) {
+  getOrCreateSanitizerCtorAndInitFunctions(
----------------
nit: static unneeded here


================
Comment at: llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp:163
+PreservedAnalyses ThreadSanitizerPass::run(Module &M,
+                                           AnalysisManager<Module> &AM) {
+  insertModuleCtor(M);
----------------
nit: `ModuleAnalysisManager &MAM`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68832/new/

https://reviews.llvm.org/D68832



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits