This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0f22fe04a5c: [RISCV] Use compiler-rt if no GCC installation
detected (authored by edward-jones).
Changed prior to commit:
https://reviews.llvm.org/D68407?vs=229284&id=230708#toc
Repository:
rG LLVM
lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.
Nice, LGTM! Thanks for fixing this in the presence of `CLANG_DEFAULT_RTLIB`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68407/new/
https://reviews.llvm.org/D68407
__
edward-jones updated this revision to Diff 229284.
edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no
GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation
detected".
edward-jones added a comment.
Added tests that a user can specify a specific ru
lenary requested changes to this revision.
lenary added a comment.
This revision now requires changes to proceed.
Please can you add a test for riscv32 and riscv64 without libgcc?
I also think you want to be smarter about detecting the need/request for
libgcc. Look for `AddRunTimeLibs` in clang/
edward-jones updated this revision to Diff 223209.
edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no
GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation
detected".
edward-jones added a comment.
Herald added subscribers: arichardson, emaste.
Her