lenary requested changes to this revision. lenary added a comment. This revision now requires changes to proceed.
Please can you add a test for riscv32 and riscv64 without libgcc? I also think you want to be smarter about detecting the need/request for libgcc. Look for `AddRunTimeLibs` in clang/lib/Driver/ToolChains/CommonArgs.cpp - I think that will get you quite far. I think you can override `getCompilerRTArgString` for your toolchain, and also `GetDefaultRuntimeLibType`. For the correct compiler-rt stuff, you want `ToolChain::getCompilerRT` I think. Using all these methods should make these path additions a lot more robust. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
