This revision was automatically updated to reflect the committed changes.
Closed by commit rL373710: [CodeComplete] Ensure object is the same in
compareOverloads() (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commi
ilya-biryukov added inline comments.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1188
ExprValueKind ObjectKind) {
+ // This function does not take object type into account.
+ if (Candidate.getDeclContext() != Incumbent.getDeclContext
ilya-biryukov updated this revision to Diff 223160.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68335/new/
https://reviews.llvm.org/D68335
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2565
+ EXPECT_THAT(Completions,
+ ElementsAre(AllOf(ReturnType("int"), Named("size";
+}
could you give the three methods different return types
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(oops, meant to accept with comments)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68335/new/
https://reviews.llvm.org/D68335
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
This fixes a regression that led to size() not being available in clangd
when completing 'deque().^'.
Repository:
rG
