ilya-biryukov added inline comments.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1188
ExprValueKind ObjectKind) {
+ // This function does not take object type into account.
+ if (Candidate.getDeclContext() != Incumbent.getDeclContext())
----------------
sammccall wrote:
> This comment is a little confusing: the very next line takes object type into
> account :-)
>
> Maybe: `// Base/derived shadowing is handled elsewhere.`
I also did not like it, thanks for the great suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68335/new/
https://reviews.llvm.org/D68335
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
