This revision was automatically updated to reflect the committed changes.
Closed by commit rL371079: [ARM] Add support for the s,j,x,N,O inline asm
constraints (authored by dcandler, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D65863?vs=214205&id=218927#toc
Repository:
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM with one small change.
Comment at: clang/test/Sema/arm_inline_asm_constraints.c:47
+// I: An immediate integer valid for a data-processing instruction.
(ARM/Thumb
dcandler added a comment.
Ping. @compnerd any other changes before this could be accepted?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65863/new/
https://reviews.llvm.org/D65863
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
dcandler updated this revision to Diff 214205.
dcandler marked an inline comment as done.
dcandler added a comment.
Adjusted the formatting on some comment lines, and added FIXMEs for all the
constraints that require additional validation to clarify what is still needed
and where.
CHANGES SINC
dcandler marked 5 inline comments as done.
dcandler added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:938
+// Thumb1: An immediate integer which is a multiple of 4 between 0 and
1020.
+Info.setRequiresImmediate();
return true;
compn
compnerd added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:904
+ case 'j': // An immediate integer between 0 and 65535 (valid for MOVW)
+if (CPUAttr.equals("6T2") ||
+ArchVersion >= 7) // only available in ARMv6T2 and above
I would h
dcandler created this revision.
dcandler added reviewers: rsmith, t.p.northover, compnerd, void, joerg,
efriedma, ostannard.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls,
javed.absar.
Herald added projects: clang, LLVM.
A number of inline assembly constraints are
