dcandler marked 5 inline comments as done.
dcandler added inline comments.
================
Comment at: clang/lib/Basic/Targets/ARM.cpp:938
+ // Thumb1: An immediate integer which is a multiple of 4 between 0 and
1020.
+ Info.setRequiresImmediate();
return true;
----------------
compnerd wrote:
> Can we leave this as a FIXME? This needs additional validation on the input.
I think it's not just the `M` constraint that requires additional validation.
Most of these immediate constraints require values that can fit in specific
encodings to be valid, or have properties like being a multiple of a number,
but `setRequiresImmediate` at present can only check against a min/max or exact
values.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65863/new/
https://reviews.llvm.org/D65863
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
