[PATCH] D65573: Add User docs for ASTImporter

martong marked 3 inline comments as done. martong added a comment. In D65573#1625881 , @a_sidorin wrote: > That's incredible. Thank you! Thanks Alexei for the review! I commited a fix for the typos. Comment at: cfe/trunk/docs/LibASTIm

[PATCH] D65573: Add User docs for ASTImporter

a_sidorin added a comment. That's incredible. Thank you! Comment at: cfe/trunk/docs/LibASTImporter.rst:215 +Node *Result = +const_cast(MatchRes[0].template getNodeAs("bindStr")); +assert(Result); We can avoid const_cast if we change the example

[PATCH] D65573: Add User docs for ASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rL368009: Add User docs for ASTImporter (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6557

[PATCH] D65573: Add User docs for ASTImporter

martong updated this revision to Diff 213332. martong added a comment. - Add description for `-ast-merge` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65573/new/ https://reviews.llvm.org/D65573 Files: clang/docs/LibASTImporter.rst clang/docs/

[PATCH] D65573: Add User docs for ASTImporter

martong marked 23 inline comments as done. martong added a comment. Thanks for the review! Comment at: clang/docs/LibASTImporter.rst:19 +``ASTContext`` holds long-lived AST nodes (such as types and decls) that can be referred to throughout the semantic analysis of a file. +The

[PATCH] D65573: Add User docs for ASTImporter

martong updated this revision to Diff 213046. martong marked 5 inline comments as done. martong added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65573/new/ https://reviews.llvm.org/D65573 Files: clang/docs/LibAST

[PATCH] D65573: Add User docs for ASTImporter

gamesh411 added a comment. Lovely documentation with practical use-cases! I left a few inline remarks. Also wouldn't it be nice to have a section which introduces the `-ast-merge` command-line option. It would be helpful to see an example where a PCH is dumped and merged into another TU. You cou

[PATCH] D65573: Add User docs for ASTImporter

shafik added a comment. Thank you for writing this up! I just have a few minor comments. Comment at: clang/docs/LibASTImporter.rst:110 + +Now we create the Importer and do the import: + Maybe helpful to link to the [Matching the Clang AST](https://clang.llvm.o

[PATCH] D65573: Add User docs for ASTImporter

aprantl added a comment. Thanks, the extra documentation is highly appreciated! Comment at: clang/docs/LibASTImporter.rst:19 +``ASTContext`` holds long-lived AST nodes (such as types and decls) that can be referred to throughout the semantic analysis of a file. +There are case

[PATCH] D65573: Add User docs for ASTImporter

martong created this revision. martong added reviewers: a_sidorin, shafik, gamesh411, balazske. Herald added subscribers: cfe-commits, Szelethus, arphaman, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. This document includes the description of the ASTImporter