martong marked 3 inline comments as done.
martong added a comment.
In D65573#1625881 <https://reviews.llvm.org/D65573#1625881>, @a_sidorin wrote:
> That's incredible. Thank you!
Thanks Alexei for the review! I commited a fix for the typos.
================
Comment at: cfe/trunk/docs/LibASTImporter.rst:215
+ Node *Result =
+ const_cast<Node *>(MatchRes[0].template getNodeAs<Node>("bindStr"));
+ assert(Result);
----------------
a_sidorin wrote:
> We can avoid const_cast if we change the example function signature to `const
> Node *`.
Indeed... Still, I did not change that to keep consistency with other parts of
the examples.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65573/new/
https://reviews.llvm.org/D65573
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
