[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. In D65543#2123200 , @dmajor wrote: > In that case, more specifically, the problem I'm seeing is that these flags > are not making it through to a small handful of files: LLVMHello.dll, > PrintFunctionNames.dll, AnnotateFunctions.d

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. In D65543#2122942 , @dmajor wrote: > After this change, PGO builds of clang on Windows can no longer find > `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could > potentially make this seamless? Or is it expected th

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. After this change, PGO builds of clang on Windows can no longer find `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could potentially make this seamless? Or is it expected that the burden is on the user to set up the paths manually during the `LLVM_BUILD_I

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8000c0ce845: [Windows] Autolink with basenames and add libdir to libpath (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https:

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

hans added a comment. The docs look great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 259751. rnk added a comment. - Lots of documentation words Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I agree with the sentiment that it's annoying when clang doesn't just work out of the box. But it will still do, except for asan and profile info etc, for which I think it's reasonable to add to t

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. I believe folks are in agreement about this direction, but I'm waiting for someone to mark the revision accepted. Let me know if that's not the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llv

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 250068. rnk added a comment. - rebase, ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/ToolChain.h

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. I ran into this issue again, and would like to move forward with this. I'll rebase it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 ___

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 232975. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/ToolChain.h clang/

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. One last idea is that we could teach LLD to automatically add this directory to library search path, but then users who link with Visual C++ (not many anymore) will run into this as a corner case issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. In D65543#1691819 , @mstorsjo wrote: > Another slightly related thread, regarding libs from the clang resource dir > and how they are specified to the linker (regarding the builtins library): > https://reviews.llvm.org/D51440 I sup

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 223128. rnk added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. - Fix PGO build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 F

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

mstorsjo added a comment. Another slightly related thread, regarding libs from the clang resource dir and how they are specified to the linker (regarding the builtins library): https://reviews.llvm.org/D51440 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

thakis added a comment. /Brepro seems orthogonal to me. If you only pass relative paths and -no-canonical-prefixes then the embedded path is relative and doesn't impeded determinism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https:

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

pcc added a comment. Another option would be to let the behaviour be controlled by `/Brepro`, so that the default behaviour would be to embed the path, while `/Brepro` builds would only embed the basename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

russell.gallop added a comment. > The other thing worth checking is the clang PGO self-host on Windows. > This has the potential to break that, and the fix would be to add a linker > flag in LLVM's cmake. This does indeed break PGO self-host with lld-link (applied on top of r373200): <...>\b

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

thakis added a comment. If you strongly feel that this is the right direction, go for it, you're code owner here :) To me, this feels like a regression. This change has no benefit that I can see (at least none that anybody's asked for that I'm aware of – then again I read llvm's bugzilla less

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. I happened to notice that I felt the same way about this in 2014 that I do today: https://reviews.llvm.org/D4428#56536 That makes me feel like I should keep pushing for this change, even though so far people don't seem enthusiastic about it. :) I changed the driver to add t