rnk added a comment.

I happened to notice that I felt the same way about this in 2014 that I do 
today:
https://reviews.llvm.org/D4428#56536
That makes me feel like I should keep pushing for this change, even though so 
far people don't seem enthusiastic about it. :)

I changed the driver to add the library path to the link line when the driver 
is used to link. This fixes the vanilla GCC-style driver usage in the ubsan 
test suite.

Obviously, most users of clang-cl don't use clang-cl to link, so they won't get 
this behavior, but in the absence of documentation, it shows how things are 
intended to work. Chromium already happens to put clang's library directory on 
the link line, so everything should work for them.

Does this seem like reasonable behavior for now? I'd modify the msbuild 
integration myself to make this stuff work out of the box, but I honestly don't 
know how to test it or change it. The other thing worth checking is the clang 
PGO self-host on Windows. This has the potential to break that, and the fix 
would be to add a linker flag in LLVM's cmake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65543/new/

https://reviews.llvm.org/D65543



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to