[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman closed this revision. aaron.ballman added a comment. I committed on your behalf in cc3c935da24c8ebe4fd92638574462b762d92335 , thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas added a comment. Hi, if this patch still LGTY, could you commit it on my behalf? I don't have commit access. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mail

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

Mordante added a comment. Thanks for updating the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 231615. nicolas added a comment. Update the comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Type.h clang/lib/AST/ASTContext.cpp c

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor commenting request. Comment at: clang/include/clang/AST/Decl.h:2400 + /// Attempt to compute an informative source range covering the +

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 231604. nicolas added a comment. Hi @mordante, thanks for the interest. Here's an updated patch that addresses @aaron.ballman's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/includ

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

Mordante added a comment. I've been looking at a way to get the ellipsis location so I'd like this patch to move forward. @nicolas are you still working on this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 __

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman added a comment. Phab looked to be having disk issues when I added my comments, so I'm pinging this review just to be sure the latest comments make it to the mailing list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 212061. nicolas added a comment. Add a default value for `FunctionProtoType::getEllipsisLoc` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

riccibruno added inline comments. Comment at: clang/include/clang/AST/Type.h:4048 +return *getTrailingObjects(); + } + And what if there is no ellipsis ? Shouldn't you do something like `return isVariadic() ? *getTrailingObjects() : SourceLocation();` inst

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 212055. nicolas edited the summary of this revision. nicolas added a comment. - `getEllipsisSourceRange` -> `getEllipsisLoc` - Updated the doc comment - Removed `auto` where necessary CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:1928 + /// macro. Otherwise, it returns the location of the end of the ellipsis. + SourceRange getEllipsisSourceRange() const { +const auto *FPT = getType()->getAs(); Why a sour

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 211849. nicolas edited the summary of this revision. nicolas added a comment. I added the SourceLocation of the ellipsis to `FunctionProtoType` in addition to the `Variadic` boolean. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:2331 + /// Attempt to compute an informative source range covering the + /// function parameters. This omits the ellipsis of a variadic function. + SourceRange getParametersSourceRange() const; ---

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas marked an inline comment as done. nicolas added inline comments. Comment at: clang/include/clang/AST/Decl.h:2331 + /// Attempt to compute an informative source range covering the + /// function parameters. This omits the ellipsis of a variadic function. + SourceRange g

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 206446. nicolas added a comment. - Added tests of instance and static functions - Added tests of parameters with cv qualifiers - Added tests of parameters with attributes - Removed `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ http

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:2331 + /// Attempt to compute an informative source range covering the + /// function parameters. This omits the ellipsis of a variadic function. + So

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas created this revision. nicolas added reviewers: rsmith, steveire. Herald added a project: clang. Herald added a subscriber: cfe-commits. This source range covers the list of parameters of the function declaration. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63276 Fi