aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a minor commenting request. ================ Comment at: clang/include/clang/AST/Decl.h:2400 + /// Attempt to compute an informative source range covering the + /// function parameters, excluding the parentheses. The source range is + /// invalid if there are no parameters. ---------------- You should make the comment clear that this will include the ellipsis (which is sort of a parameter, sort of not). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
