[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks Dmitri! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

This revision was automatically updated to reflect the committed changes. Closed by commit rL362702: [clang-tidy] Make the plugin honor NOLINT (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 203306. nik marked 2 inline comments as done. nik added a comment. Addressed inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files: clang-tidy/ClangTidyDi

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:207 CheckNamesByDiagnosticID.try_emplace(ID, CheckName); + CustomDiagIdParamsByDiagnosticID.try_emplace( + ID, CustomDiagIdParams(Level, FormatString))

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

gribozavr added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:472 if (Info.hasSourceManager()) checkFilters(Info.getLocation(), Info.getSourceManager()); } nik wrote: > gribozavr wrote: > > It seems like the `checkFilters` call

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 200736. nik marked an inline comment as done. nik added a comment. Addressed comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files: clang-tidy/ClangTidyDiagnosti

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added a comment. As I've commented on, this change is not finished. However, I've addressed the inline comments nevertheless. There is one TODO left for which I would like to have an opinion. Comment at: clang-tidy/ClangTidyDiagnostic

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

gribozavr added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:457 + forwardDiagnostic(Info); + return; + } Indentation is 2 spaces. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:472 if (Info.hasS

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. alexfh? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 198637. nik added a comment. The plugin makes use of ClangTidyDiagnosticConsumer and forwards diagnostics to the external diagnostic engine. @alexfh: What do you think? If that looks roughly OK for you, I'll finish it. Repository: rCTE Clang Tools Extra CHAN

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks for the fast comments! In D61487#1489308 , @alexfh wrote: > I suspect that we're missing proper test coverage here. True, ideally all the test scripts would also trigger the plugin case code path. I've started with a modifie

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

alexfh added a comment. Apart from NOLINT handling there's more logic in `ClangTidyDiagnosticConsumer::HandleDiagnostic`, which isn't properly transferred to `ClangTidyContext::diag` in this patch. The logic that is transferred seems to change the behavior w.r.t. notes that can "unmute" ignored

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. This one depends on https://reviews.llvm.org/D61486 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The clang-tidy standalone tool implements the NOLINT filtering in ClangTidyDiagnosticConsumer::HandleDiagnostic. For the plugin case no ClangTidyDiagnosticConsumer is set up as it would have