nik marked 4 inline comments as done. nik added inline comments.
================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:207 CheckNamesByDiagnosticID.try_emplace(ID, CheckName); + CustomDiagIdParamsByDiagnosticID.try_emplace( + ID, CustomDiagIdParams(Level, FormatString)); ---------------- gribozavr wrote: > Did you consider adding this query API to DiagnosticIDs instead? To me it > looks weird that creation of custom diag IDs is handled by one class > (DiagnosticIDs), and queries -- by another (ClangTidyContext). Huch, that query API is already there. For some reason, I've missed it. Good catch, thanks! :) ================ Comment at: test/clang-tidy/nolintnextline-plugin.cpp:47 + +// RUN: c-index-test -test-load-source-reparse 2 all %s -Xclang -add-plugin -Xclang clang-tidy -Xclang -plugin-arg-clang-tidy -Xclang -checks='-*,google-explicit-constructor' 2>&1 | FileCheck %s ---------------- gribozavr wrote: > Why not on the first line? As this file is based on test/clang-tidy/nolint.cpp, I left it at is. But having it at top looks more common, so I've moved it there now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
