This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL357114: [clang-tidy] Handle missing yaml module in
run-clang-tidy.py (authored by zinovy.nis, committed by ).
Herald added
zinovy.nis updated this revision to Diff 192137.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59734/new/
https://reviews.llvm.org/D59734
Files:
clang-tidy/tool/run-clang-tidy.py
test/clang-tidy/run-clang-tidy.cpp
Index: test/clang-tidy/run-clang-tidy.cpp
==
zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.
Comment at: clang-tidy/tool/run-clang-tidy.py:210
+help='Create a yaml file to store suggested fixes in, '
+'which can be applied with clang-apply-replac
serge-sans-paille added inline comments.
Comment at: clang-tidy/tool/run-clang-tidy.py:210
+help='Create a yaml file to store suggested fixes in, '
+'which can be applied with clang-apply-replacements.')
parser.add_argument('-j',
serge-sans-paille added inline comments.
Comment at: clang-tidy/tool/run-clang-tidy.py:51
+
+yaml_imported = True
+try:
Could be
```
try:
import yaml
except ImportError:
yaml = None
```
and later
```
if yaml:
...
```
CHANGES SINCE LAST ACTION
h
zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.
Comment at: test/clang-tidy/run-clang-tidy.cpp:1
+// RUN: %run_clang_tidy --help
// RUN: rm -rf %t
Just check that python doesn't complain on the script code and imported modules.
C
zinovy.nis updated this revision to Diff 191992.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59734/new/
https://reviews.llvm.org/D59734
Files:
clang-tidy/tool/run-clang-tidy.py
test/clang-tidy/run-clang-tidy.cpp
Index: test/clang-tidy/run-clang-tidy.cpp
==
zinovy.nis created this revision.
zinovy.nis added reviewers: alexfh, bkramer, kuhar.
zinovy.nis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a reviewer: serge-sans-paille.
Herald added a project: clang.
The Yaml module is missing on some syste
