zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.


================
Comment at: clang-tidy/tool/run-clang-tidy.py:210
+                        help='Create a yaml file to store suggested fixes in, '
+                        'which can be applied with clang-apply-replacements.')
   parser.add_argument('-j', type=int, default=0,
----------------
serge-sans-paille wrote:
> could be
> 
> ```
> if yaml:
>     parser.add_argument('-export-fixes', metavar='filename', 
> dest='export_fixes',
>       ​                        help='Create a yaml file to store suggested 
> fixes in, '
>       ​                        'which can be applied with 
> clang-apply-replacements.')
> else:
>     parser.export_fixes = False
> ```
> 
> This would make later condition easier to read.
Looks strange. Not sure this works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59734/new/

https://reviews.llvm.org/D59734



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to