This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL356446: [Tooling] Add more scope specifiers until spelling
is not ambiguous. (authored by ioeric, committed by ).
Herald added a project: LLVM.
Herald added a subsc
kadircet added inline comments.
Comment at: lib/Tooling/Core/Lookup.cpp:165
+if (UnspelledScopes.empty()) {
+ Disambiguated = "::" + Disambiguated;
+} else {
ioeric wrote:
> kadircet wrote:
> > maybe return or break afterwards?
> I also struggled a b
ioeric marked 2 inline comments as done.
ioeric added inline comments.
Comment at: lib/Tooling/Core/Lookup.cpp:165
+if (UnspelledScopes.empty()) {
+ Disambiguated = "::" + Disambiguated;
+} else {
kadircet wrote:
> maybe return or break afterwards?
I
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Tooling/Core/Lookup.cpp:165
+if (UnspelledScopes.empty()) {
+ Disambiguated = "::" + Disambiguated;
+} else {
maybe ret
ioeric created this revision.
ioeric added reviewers: kadircet, gribozavr.
Herald added subscribers: cfe-commits, jdoerfert.
Herald added a project: clang.
Previously, when the renamed spelling is ambiguous, we simply use the
full-qualfied name (with leading "::"). This patch makes it try adding
a
