[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505682 , @Szelethus wrote: > In that case, feel free to revert this. If around 11:00 CET time I tried to > recommit with a possible fix (while watching your bots), would that be an > issue? I managed to reproduce this

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. In that case, feel free to revert this. If around 11:00 CET time I tried to recommit with a possible fix (while watching your bots), would that be an issue? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.o

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added inline comments. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE Szelethus wrote: > Szel

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin P

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus marked 2 inline comments as done. Szelethus added a comment. If there's a cmake variable for fuchsia, Could you please try to add them here? (see inlines) I don't have access to that particular platform. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyH

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505463 , @NoQ wrote: > Can we have a full build log? The full build log is here: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8913271285442739696 Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. In D59464#1505435 , @phosek wrote: > In D59464#1505323 , @Szelethus wrote: > > > I started to land other patches as well that depend on this one -- I won't > > object, but I'd prefer to f

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

NoQ added a comment. Can we have a full build log? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505323 , @Szelethus wrote: > I started to land other patches as well that depend on this one -- I won't > object, but I'd prefer to find a solution, mostly because I don't even know > how I could reproduce this error. T

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Also, am I supposed to receive a mail from your buildbots? I unfortunately received none. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-co

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus marked an inline comment as done. Szelethus added a comment. In D59464#1505200 , @phosek wrote: > All our bots are failing which seems to have been caused by the latest reland: > > FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) > **

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. All our bots are failing which seems to have been caused by the latest reland: FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) TEST 'Clang :: Analysis/checker-plugins.c' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL360891: Reland "[analyzer] Add an example plugin for checker dependency handling" (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D59464?vs=199663&id=199807#toc

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ugh. Reverted in rC360805 . Buildbots don't seem to be able to find the new plugins. Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL360799: [analyzer] Add a test for plugins using checker dependencies (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I can't say "no" to more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits maili

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus updated this revision to Diff 196083. Szelethus added a comment. - Move the existing plugin to `test/` - Implement the new plugin in there also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 Files: examples/CMakeLists.txt examples

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity, mgorny. - Move `examples/anal