Szelethus marked an inline comment as done. Szelethus added a comment. In D59464#1505200 <https://reviews.llvm.org/D59464#1505200>, @phosek wrote:
> All our bots are failing which seems to have been caused by the latest reland: > > FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) > ******************** TEST 'Clang :: Analysis/checker-plugins.c' FAILED > ******************** > Script: > -- > : 'RUN: at line 1'; > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 > -internal-isystem > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include > -nostdsysteminc -analyze -analyzer-constraints=range -verify > /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -load > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/SampleAnalyzerPlugin.so > -analyzer-checker='example.MainCallChecker' > : 'RUN: at line 15'; > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 > -internal-isystem > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include > -nostdsysteminc -analyze -analyzer-constraints=range > /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -load > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/CheckerDependencyHandlingAnalyzerPlugin.so > -analyzer-checker=example.DependendentChecker > -analyzer-list-enabled-checkers 2>&1 | > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/FileCheck > /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c > -check-prefix=CHECK-IMPLICITLY-ENABLED > : 'RUN: at line 24'; > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 > -internal-isystem > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include > -nostdsysteminc -analyze -analyzer-constraints=range > /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -load > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/CheckerDependencyHandlingAnalyzerPlugin.so > -analyzer-checker=example.DependendentChecker > -analyzer-disable-checker=example.Dependency > -analyzer-list-enabled-checkers 2>&1 | > /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/FileCheck > /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c > -check-prefix=CHECK-IMPLICITLY-DISABLED > -- > Exit Code: 1 > > Command Output (stderr): > -- > error: 'error' diagnostics seen but not expected: > (frontend): unable to load plugin > '/b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/SampleAnalyzerPlugin.so': > > '/b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/SampleAnalyzerPlugin.so: > undefined symbol: _ZN4llvm14FoldingSetBase6anchorEv' > > -- > > ******************** > Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. > Testing Time: 77.86s > ******************** > Failing Tests (1): > Clang :: Analysis/checker-plugins.c > > > Is it possible to revert this change again? I started to land other patches as well that depend on this one -- I won't object, but I'd prefer to find a solution, mostly because I don't even know how I could reproduce this error. The thing is, I merely moved some files from one directory to the other, which makes me scratch my head even more. That being said -- (see inlines) If it's urgent, feel free to revert, I won't be near a computer until tomorrow. ================ Comment at: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(SampleAnalyzerPlugin PRIVATE ---------------- Is it possible that if we tweaked this line the error would go away? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits