[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rL356676: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri updated this revision to Diff 191701. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Last nit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 Files: docs/LibASTMatchersReference.htm

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6444-6445 + internal::Matcher, InnerMatcher) { + if (isStandaloneDirective().matches(Node, Finder, Builder)) +return false; // Standalone directives have no structured blocks.

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a NFC change Comment at: include/clang/ASTMatchers/ASTMatchers.h:6444-6445 + internal::Matcher, InnerMatcher) { + if (isStandaloneDirective().matches(Node, Finder, Builder)) +

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri added a comment. @gribozavr thank you for the review! @aaron.ballman any comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 ___ cfe-commits mailing list cfe-

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri updated this revision to Diff 191676. lebedev.ri marked 6 inline comments as done. lebedev.ri added a comment. Rebased, addressed all(?) nits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 Files: docs/LibAS

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6389 +/// Given OpenMP directive, matches if it is an OpenMP standalone directive, +/// i.e. an executable directive with no structured block. "Matches standalone OpenMP direct

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6421 +/// +/// Prerequisite: the executable directive must not be standalone directive. +/// lebedev.ri wrote: > aaron.ballman wrote: > > What happens if this prereq is not met?

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6421 +/// +/// Prerequisite: the executable directive must not be standalone directive. +/// aaron.ballman wrote: > What happens if this prereq is not met? Does the matcher retu

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6421 +/// +/// Prerequisite: the executable directive must not be standalone directive. +/// What happens if this prereq is not met? Does the matcher return false, or does i

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

lebedev.ri created this revision. lebedev.ri added reviewers: gribozavr, aaron.ballman, JonasToth, george.karpenkov. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: jdoerfert, guansong. Exposes the interface being added in D59214 for ASTMatch