lebedev.ri added inline comments.
================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:6421 +/// +/// Prerequisite: the executable directive must not be standalone directive. +/// ---------------- lebedev.ri wrote: > aaron.ballman wrote: > > What happens if this prereq is not met? Does the matcher return false, or > > does it do something worse (like assert)? > From https://reviews.llvm.org/D59214#change-5GOe7CiMwWxl > ``` > const Stmt *OMPExecutableDirective::getStructuredBlock() const { > assert(!isStandaloneDirective() && > "Standalone Executable Directives don't have Structured Blocks."); > ``` > It really doesn't make sense to return false/nullptr, > it would be like trying to find ForLoop in VarDecl, they are just really > distinct types. Hmm, actually, i guess it would be best to return false here instead then. Will change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59463/new/ https://reviews.llvm.org/D59463 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
