[PATCH] D58891: Modules: Add -Rmodule-import

2019-03-05 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith marked 2 inline comments as done. dexonsmith added a comment. Committed in r355477. Comment at: clang/test/Modules/Inputs/Rmodule-import/B.h:1 +// B +#include "C.h" bruno wrote: > Can you make one of the tests to use

[PATCH] D58891: Modules: Add -Rmodule-import

2019-03-04 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice, note that a subset of this information can be achieved with `-Wauto-import`, but this is way more general and solid, since it will handles `@import`s and pragma imports too. LGTM with a mi

[PATCH] D58891: Modules: Add -Rmodule-import

2019-03-03 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/test/Modules/Rmodule-build.m:22-25 -// RUN: echo ' ' >> %t/C.h -// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fsyntax-only %s -I %t \ -// RUN:

[PATCH] D58891: Modules: Add -Rmodule-import

2019-03-03 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, bruno, rsmith, vsapsai. Herald added a subscriber: jdoerfert. Add a remark for importing modules. Depending on whether this is a direct import (into the TU being built by this compiler instance) or transitive import (into an