bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land.
Nice, note that a subset of this information can be achieved with `-Wauto-import`, but this is way more general and solid, since it will handles `@import`s and pragma imports too. LGTM with a minor nitpick, see comments. ================ Comment at: clang/test/Modules/Inputs/Rmodule-import/B.h:1 +// B +#include "C.h" ---------------- Can you make one of the tests to use `@import` (or the pragma version) instead of #include? ================ Comment at: clang/test/Modules/Rmodule-build.m:22-25 -// RUN: echo ' ' >> %t/C.h -// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -fsyntax-only %s -I %t \ -// RUN: -Reverything 2>&1 | FileCheck %s - ---------------- dexonsmith wrote: > @bruno this looked redundant to me with the check above; can you confirm? > (Now that we have `-Rmodule-import`, the FileCheck was failing...) Yes, it should be fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58891/new/ https://reviews.llvm.org/D58891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
