[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350741: [AST] Move back BasePathSize to the bit-fields of CastExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56358?vs=180377&id=180854#toc Repository:

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); riccibruno w

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); lebedev.ri w

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

lebedev.ri added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); riccibruno wrote: > lebedev.ri wrote: > > rjmccall wrote:

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); lebedev.ri w

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG in principle. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); asse

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

rjmccall added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); riccibruno wrote: > lebedev.ri wrote: > > riccibruno wrote:

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); lebedev.ri w

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

lebedev.ri added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); riccibruno wrote: > It cannot overflow now, but someone i

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); It cannot ov

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno created this revision. riccibruno added a reviewer: lebedev.ri. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Background: The number of trailing `CXXBaseSpecifiers` in `CastExpr` was moved from `CastExprBitfields` to a trailing object in r338489 (D50050