riccibruno marked 2 inline comments as done. riccibruno added inline comments.
================ Comment at: include/clang/AST/Expr.h:3029 + assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); ---------------- It cannot overflow now, but someone in the future is going to shrink `CastExprBitfields::BasePathSize`. ================ Comment at: include/clang/AST/Stmt.h:487 + /// here. ([implimits] Direct and indirect base classes [16384]). + unsigned BasePathSize; }; ---------------- Feel free to find a better comment here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56358/new/ https://reviews.llvm.org/D56358 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits