This revision was automatically updated to reflect the committed changes.
Closed by commit rG7681435de148: [clang-format] Assert that filenames are not
empty (authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56345/new/
http
mitchell-stellar accepted this revision.
mitchell-stellar added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56345/new/
https://reviews.llvm.org/D56345
___
cfe-commits mailin
MyDeveloperDay commandeered this revision.
MyDeveloperDay edited reviewers, added: jr; removed: MyDeveloperDay.
MyDeveloperDay added a comment.
This revision now requires review to proceed.
@jr As there is no response from you, I wonder if you are ok with me taking
this over, I'd like to recommen
MyDeveloperDay updated this revision to Diff 228014.
MyDeveloperDay added a reviewer: mitchell-stellar.
MyDeveloperDay added a comment.
remove the asserts at least for now.
This fix is important for people using clang-format integrated into some
editor tools.
CHANGES SINCE LAST ACTION
https
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
Thanks for the patch, I'm sorry it's taken so long sometimes items get
lost...This looks to still be relevant, I think you'll need to rebase but it
LGTM
$ clang-format --ass
jr created this revision.
jr added reviewers: krasimir, djasper.
Herald added a subscriber: cfe-commits.
Adds asserts to catch empty filenames, which otherwise will cause a crash in
SourceManager.
The clang-format tool now outputs an error if an empty filename is used.
Fixes bug: 34667
Reposito
