MyDeveloperDay commandeered this revision.
MyDeveloperDay edited reviewers, added: jr; removed: MyDeveloperDay.
MyDeveloperDay added a comment.
This revision now requires review to proceed.
@jr As there is no response from you, I wonder if you are ok with me taking
this over, I'd like to recommend we keep just the:
if (AssumedFileName.empty()) {
llvm::errs() << "error: empty filenames are not allowed\n";
return true;
}
For now, as the other functions where you are adding an assert might be being
called from other tooling areas and I don't want to cause others problems, I'd
like to keep this change localized, (I hope it's ok but I'll rebase and update
the patch)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56345/new/
https://reviews.llvm.org/D56345
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
