[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:78 +RecTy = Context.getAddrSpaceQualType( +RecTy, MD->getTypeQualifiers().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(Rec

[PATCH] D56066: [OpenCL] Address space for default class members

This revision was automatically updated to reflect the committed changes. Closed by commit rL351053: [OpenCL] Set generic addr space of 'this' in special class members. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Great, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 ___ cfe-commits mailing list c

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked 6 inline comments as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:813 + case CK_AddressSpaceConversion: { +Visit(E->getSubExpr()); +break; rjmccall wrote: > If there's a `Dest`, you might need to reverse-c

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181256. Anastasia added a comment. - Set correctly value kind of address space conversion after materializing the temporary - Removed changes in various places including CodeGen for address space conversion that became unnecessary after the AST is generate

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/AST/Expr.cpp:1618 assert(getValueKindForType(Ty) == Expr::getValueKindForType(SETy)); -if (!isGLValue()) +if (!isGLValue() && !getSubExpr()->isXValue()) { Ty = Ty->getPointeeType(); What's this a

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181114. Anastasia added a comment. Removed FIXME that this patch fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: include/clang/Sema/Sema.h lib/AST/Expr.cpp lib/CodeGen/CGCall.cpp lib/

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 181112. Anastasia added a comment. Modified conversion sequence to perform address space conversion after temporary materialization conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: inc

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + Anastasia wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > rjmccall wr

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + rjmccall wrote: > ebevhan wrote: > > rjmccall wrot

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + ebevhan wrote: > rjmccall wrote: > > rjmccall wrote: > > > I can understand why a pr-value woul

[PATCH] D56066: [OpenCL] Address space for default class members

ebevhan added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + rjmccall wrote: > rjmccall wrote: > > I can understand why a pr-value wouldn't have an address s

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + rjmccall wrote: > I can understand why a pr-value wouldn't have an address space, but an > x-v

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:78 +RecTy = Context.getAddrSpaceQualType( +RecTy, MD->getTypeQualifiers().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(Rec

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 179899. Anastasia added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: include/clang/Sema/Sema.h lib/CodeGen/CGCall.cpp lib/Sema/SemaDecl.cpp lib/Sema/

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:78 +RecTy = Context.getAddrSpaceQualType( +RecTy, MD->getTypeQualifiers().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(RecTy)); Would you mind making

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Herald added a subscriber: yaxunl. Fixed several issues reported in https://reviews.llvm.org/D55656 and https://reviews.llvm.org/D54862 - mainly removed addr space from the `QualType` of the method itself. This shoul