This revision was automatically updated to reflect the committed changes.
Closed by commit rL348797: Re-order content of template parameter dumps
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55393?vs=177412&id
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor nits
Comment at: lib/AST/ASTDumper.cpp:106
+ const Decl *From = nullptr,
+
steveire updated this revision to Diff 177412.
steveire added a comment.
New approach
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55393/new/
https://reviews.llvm.org/D55393
Files:
lib/AST/ASTDumper.cpp
test/AST/ast-dump-decl.cpp
Index: test/AST/ast-dump-d
aaron.ballman added inline comments.
Comment at: test/AST/ast-dump-decl.cpp:330-331
// CHECK-NEXT: TemplateTypeParmDecl
-// CHECK-NEXT: TemplateArgument type 'int'
// CHECK-NEXT: inherited from TemplateTypeParm 0x{{[^ ]*}} 'T'
+// CHECK-NEXT: TemplateArgument type
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: test/AST/ast-dump-decl.cpp:330-331
// CHECK-NEXT: TemplateTypeParmDecl
-// CHECK-NEXT: TemplateArgument type 'int'
// CHECK-NEXT: inherited from TemplateTypeParm 0x{{[^ ]*}} 'T'
+//
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: test/AST/ast-dump-decl.cpp:330-331
// CHECK-NEXT: TemplateTypeParmDecl
-// CHECK-NEXT: TemplateArgument type 'int'
// CHECK-NE
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D55393
Files:
lib/AST/ASTDumper.cpp
test/AST/ast-dump-decl.cpp
Index: test/AST/ast-dump-decl.cpp
===
