steveire marked an inline comment as done. steveire added inline comments.
================ Comment at: test/AST/ast-dump-decl.cpp:330-331 // CHECK-NEXT: TemplateTypeParmDecl -// CHECK-NEXT: TemplateArgument type 'int' // CHECK-NEXT: inherited from TemplateTypeParm 0x{{[^ ]*}} 'T' +// CHECK-NEXT: TemplateArgument type 'int' ---------------- aaron.ballman wrote: > This looks wrong to me. You did not inherit the `TemplateTypeParmDecl` from > above, you inherited the `TemplateArgument`. The order is important here and > should be preserved to avoid confusion. Should this be dumped as a child of the `TemplateArgument` then? I can add it as a child in `ASTDumper::dumpTemplateArgument`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55393/new/ https://reviews.llvm.org/D55393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits