This revision was automatically updated to reflect the committed changes.
Closed by commit rC337000: [Analyzer] alpha.unix.cstring.OutOfBounds checker
enable/disable fix (authored by baloghadamsoftware, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48831
Files:
lib/StaticAn
NoQ accepted this revision.
NoQ added a comment.
Whoops, sry, yeah, looks good, please commit!
https://reviews.llvm.org/D48831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dkrupp marked an inline comment as done.
dkrupp added a comment.
@NoQ do we need any more update to this patch? Thanks.
https://reviews.llvm.org/D48831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
baloghadamsoftware accepted this revision.
baloghadamsoftware added a comment.
This revision is now accepted and ready to land.
LGTM! But wait for Artem's acceptance before submitting.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:311
+if (!Filter.CheckCStringO
dkrupp marked 2 inline comments as done.
dkrupp added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:311
+if (!Filter.CheckCStringOutOfBounds)
+ return StOutBound;
NoQ wrote:
> Could we preserve the other portion of the ass
dkrupp updated this revision to Diff 153905.
dkrupp added a comment.
The patch has been updated.
Changes:
-The analysis path is cut if overvlow is detected even if CStringOutOfBounds is
disabled
The assert(Filter.CheckCStringOutOfBounds || Filter.CheckCStringNullArg);
cannot be put back, becau
NoQ added a comment.
Uhm, so we had an alpha checker enabled all along? Thanks for patching this up!
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:308
// These checks are either enabled by the CString out-of-bounds checker
-// explicitly or the "basic" CSt
