[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335959: [ASTImporter] Eliminated some unittest warnings. (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47459 Files: cfe

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

balazske updated this revision to Diff 153015. balazske added a comment. Rebase to newest master. Repository: rC Clang https://reviews.llvm.org/D47459 Files: unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Thank you! When committing, please change the commit message (the current review description is out-of-date) and mention the reformatting done. Repository: rC Clang https://reviews.

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

balazske marked 2 inline comments as done. balazske added a comment. Some of the source code was reformatted for more consistency. At least a part of the code is now better formatted. Repository: rC Clang https://reviews.llvm.org/D47459 ___ cfe-

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

balazske updated this revision to Diff 152632. balazske added a comment. [ASTImporter] Fixed test code in ASTImporter tests. Reformatted some test code, changed to use isDescendant. Repository: rC Clang https://reviews.llvm.org/D47459 Files: unittests/AST/ASTImporterTest.cpp Index: unitt

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

a_sidorin added a comment. Hello Balázs, The patch is mostly LG now, thank you! Comment at: unittests/AST/ASTImporterTest.cpp:495 " struct s { int x; long y; unsigned z; }; " - " (struct s){ 42, 0L, 1U }; }", + " (void) (struct s){ 42,

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

balazske updated this revision to Diff 149079. balazske added a comment. [ASTImporter] Fixed test code in ASTImporter tests. Test code is fixed instead of turn off the warnings. For this to work change of match expressions was needed. Repository: rC Clang https://reviews.llvm.org/D47459 Fil

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

balazske added a comment. Original idea was to not modify the test code to keep it as simple as possible. If you like it better I will change the test code. Repository: rC Clang https://reviews.llvm.org/D47459 ___ cfe-commits mailing list cfe-co

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

a.sidorin requested changes to this revision. a.sidorin added a comment. This revision now requires changes to proceed. Hello Balázs! Thank you for addressing this problem, it is really cool. However, it will be much better if we don't suppress warnings but fix them. Could you modify the tests

[PATCH] D47459: [ASTImporter] Eliminated some unittest warnings.

balazske created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: a.sidorin. When running the ASTTests test, warnings produced by the compiler can be distracting when looking for test errors. A part of the warnings is remov