a_sidorin added a comment.
Hello Balázs,
The patch is mostly LG now, thank you!
================
Comment at: unittests/AST/ASTImporterTest.cpp:495
" struct s { int x; long y; unsigned z; }; "
- " (struct s){ 42, 0L, 1U }; }",
+ " (void) (struct s){ 42, 0L, 1U }; }",
Lang_CXX, "", Lang_CXX, Verifier,
----------------
Redundant space after cast.
================
Comment at: unittests/AST/ASTImporterTest.cpp:541
+ Lang_C, "", Lang_C, Verifier,
+ /*functionDecl(hasBody(compoundStmt(
has(labelStmt(hasDeclaration(labelDecl(hasName("loop"))))),
----------------
Commented code should be removed.
================
Comment at: unittests/AST/ASTImporterTest.cpp:802
Lang_CXX, "", Lang_CXX, Verifier,
- functionTemplateDecl(has(functionDecl(
- has(compoundStmt(has(cxxDependentScopeMemberExpr())))))));
+ functionTemplateDecl(has(functionDecl(has(compoundStmt(has(
+ cStyleCastExpr(has(
----------------
Sometimes we turn to usehasDescendant(), sometimes we add a cast matcher. Can
we make it consistent?
Repository:
rC Clang
https://reviews.llvm.org/D47459
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
