This revision was automatically updated to reflect the committed changes.
Closed by commit rL332854: [Clang Tablegen] Add llvm_unreachable() to
getModifierName() (authored by msearles, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47
msearles updated this revision to Diff 147809.
msearles added a comment.
Add comment per reviewer suggestion.
https://reviews.llvm.org/D47150
Files:
utils/TableGen/ClangDiagnosticsEmitter.cpp
Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
=
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:495
}
+ llvm_unreachable("invalid modifier type");
}
Perhaps this should say "unhandled cas
msearles updated this revision to Diff 147807.
msearles retitled this revision from "[Clang Tablegen] Add default case to
getModifierName()" to "[Clang Tablegen] Add llvm_unreachable() to
getModifierName()".
msearles added a comment.
Ah, yes. Adding llvm_unreachable() is better. Done.
https:/
