EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:495 } + llvm_unreachable("invalid modifier type"); } ---------------- Perhaps this should say "unhandled case" or similar? https://reviews.llvm.org/D47150 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits