[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

ldionne added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do danlark wrote: > hiraditya wrote: > > danlark wrote: > > > lichray wrote: > > > > mclow.lis

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark marked an inline comment as done. danlark added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do hiraditya wrote: > danlark wrote: > > lichray wro

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

hiraditya added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do danlark wrote: > lichray wrote: > > mclow.lists wrote: > > > I have been asked specifical

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lebedev.ri added a comment. In D44823#1375654 , @mclow.lists wrote: > In D44823#1375590 , @mclow.lists > wrote: > > > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > > original test in

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists added a comment. In D44823#1375590 , @mclow.lists wrote: > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. Pilot error - it's still the

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark added a comment. In D44823#1375590 , @mclow.lists wrote: > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. > Looking briefly at your test ca

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists added a comment. Herald added a subscriber: libcxx-commits. I just tried this (on Compiler Explorer) using LLVM 7, and the code for my original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. Looking briefly at your test case, it seems to be fixed now too. Can you

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark added inline comments. Herald added a subscriber: ldionne. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do lichray wrote: > mclow.lists wrote: > > I have been ask

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lichray added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do mclow.lists wrote: > I have been asked specifically by the optimizer folks to NOT do things

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. Please don't commit this. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__e

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lichray accepted this revision. lichray added a comment. This revision is now accepted and ready to land. Something `std::byte` couldn't help lol Repository: rCXX libc++ https://reviews.llvm.org/D44823 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark created this revision. danlark added reviewers: EricWF, mclow.lists. Herald added subscribers: cfe-commits, christof. Consider the following code. #include #include class TestClass { public: TestClass(size_t size) : Data(size) { } private: