This revision was automatically updated to reflect the committed changes.
Closed by commit rC325364: Clean up 'target' attribute diagnostics
(authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43359?vs=134643&id=134648#toc
Repository:
rC Clang
https:/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Aside from a minor wording nit, LGTM!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2448-2449
def warn_unsupported_target_attribute
-: Warning<"ignoring %select{unsupported|duplicate}0"
-
erichkeane updated this revision to Diff 134643.
erichkeane added a comment.
Do as @aaron.ballman suggested for the message. Also, removed properties from
the new file.
https://reviews.llvm.org/D43359
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/
aaron.ballman added inline comments.
Comment at: test/Sema/attr-target.c:9-10
int __attribute__((target("fpmath=387"))) walrus() { return 4; }
//expected-warning {{ignoring unsupported 'fpmath=' in the target attribute
string}}
+// expected-warning@+1 {{'target' attribute igno
erichkeane added inline comments.
Comment at: test/Sema/attr-target-ast.c:1
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -ast-dump %s | FileCheck %s
+
aaron.ballman wrote:
> Can you drop the svn props from this file?
Absolutely, I'll do that on commit.
aaron.ballman added inline comments.
Comment at: test/Sema/attr-target-ast.c:1
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -ast-dump %s | FileCheck %s
+
Can you drop the svn props from this file?
Comment at: test/Sema/attr-target.c:9-10
int _
erichkeane added a comment.
Thanks! I'll give @aaron.ballman a chance to take a look, so I'll probably do
something about this tomorrow.
https://reviews.llvm.org/D43359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Seems ok here.
https://reviews.llvm.org/D43359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
erichkeane created this revision.
erichkeane added reviewers: echristo, aaron.ballman.
There were a few issues previously with the target
attribute diagnostics implementation that lead to the
attribute being added to the AST despite having an error
in it.
This patch changes that, and adds a test
