aaron.ballman accepted this revision.
aaron.ballman added a comment.
Aside from a minor wording nit, LGTM!
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2448-2449
def warn_unsupported_target_attribute
- : Warning<"ignoring %select{unsupported|duplicate}0"
- "%select{| architecture}1 '%2' in the target attribute string">,
+ : Warning<"%select{unsupported|duplicate}0%select{| architecture}1 '%2' in"
+ " the target attribute string; target attribute ignored">,
InGroup<IgnoredAttributes>;
----------------
Can you manually quote `'target'` in the diagnostic? I know it wasn't there
before, but we try to stick quotes around syntactic constructs.
https://reviews.llvm.org/D43359
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
