benhamilton marked an inline comment as done.
benhamilton added a comment.
> I don't understand why do we introduce an enum option if we are keeping the
> default behavior for Google style. IMO we should have a single behavior for
> any style and enforce it.
https://reviews.llvm.org/D42708 chan
krasimir added a comment.
I don't understand why do we introduce an enum option if we are keeping the
default behavior for Google style. IMO we should have a single behavior for any
style and enforce it.
Repository:
rC Clang
https://reviews.llvm.org/D42650
___
benhamilton marked 2 inline comments as done.
benhamilton added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1214
// FIXME: We likely want to do this for more combinations of brackets.
// Verify that it is wanted for ObjC, too.
if (Current.is(to
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324131: [clang-format] New format param
ObjCBinPackProtocolList (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42650?vs=132187&id=132650#toc
Repository:
benhamilton added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1214
// FIXME: We likely want to do this for more combinations of brackets.
// Verify that it is wanted for ObjC, too.
if (Current.is(tok::less) && Current.ParentBracket == tok::l_pa
stephanemoore added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1214
// FIXME: We likely want to do this for more combinations of brackets.
// Verify that it is wanted for ObjC, too.
if (Current.is(tok::less) && Current.ParentBracket == tok::l_
benhamilton added a comment.
Thanks! @jolesiak is not available for the rest of the week, so should I just
submit this as-is, or wait until next week?
Repository:
rC Clang
https://reviews.llvm.org/D42650
___
cfe-commits mailing list
cfe-commits@
stephanemoore accepted this revision.
stephanemoore added a comment.
This revision is now accepted and ready to land.
Looks good to me 👌 Thanks for driving this!
Repository:
rC Clang
https://reviews.llvm.org/D42650
___
cfe-commits mailing list
cf
benhamilton updated this revision to Diff 132187.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
- BinPackObjCProtocolList -> ObjCBinPackProtocolList
Repository:
rC Clang
https://reviews.llvm.org/D42650
Files:
include/clang/Format/Format.h
lib/Format/Continuat
