This revision was automatically updated to reflect the committed changes.
Closed by commit rC323157: [ASTMatchers] [NFC] Fix code examples (authored by
MaskRay, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42213?vs=130922&id=130965#toc
Repository:
rC Clang
https://revi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you! Do you need me to commit on your behalf?
Repository:
rC Clang
https://reviews.llvm.org/D42213
___
cfe-commits m
MaskRay updated this revision to Diff 130922.
MaskRay added a comment.
Regenerate HTML docs
$ cd docs/tools # yes, cd
$ ./dump_ast_matchers.py
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
Index: in
aaron.ballman added a comment.
Great, all that remains is for you to regenerate the documentation file and
upload that with the next patch.
Repository:
rC Clang
https://reviews.llvm.org/D42213
___
cfe-commits mailing list
cfe-commits@lists.llvm.
MaskRay updated this revision to Diff 130711.
MaskRay added a comment.
functionProtoType
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
=
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982385, @MaskRay wrote:
> Yes, I was asking about this because the results seemed to be wrong. I should
> have used `parameterCountIs()` to reduce the confusion :) I'll leave them
> untouched.
Alternatively, you can try out tho
MaskRay added a comment.
In https://reviews.llvm.org/D42213#982261, @aaron.ballman wrote:
> In https://reviews.llvm.org/D42213#982256, @MaskRay wrote:
>
> > I am also not sure about this function: line 3548
> >
> > /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
> >
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982256, @MaskRay wrote:
> I am also not sure about this function: line 3548
>
> /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
> /// specific parameter count.
> ///
> /// Given
> /// \code
>
MaskRay added a comment.
I am also not sure about this function: line 3548
/// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
/// specific parameter count.
///
/// Given
/// \code
/// void f(int i) {}
/// void g(int i, int j) {}
/// void h(int i, int
MaskRay updated this revision to Diff 130672.
MaskRay added a comment.
Address comment
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
===
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982047, @MaskRay wrote:
> In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote:
>
> > The documentation needs to be regenerated for this patch. One thing that
> > seems to be inconsistent is with the "what gets matched"
MaskRay added a comment.
In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote:
> The documentation needs to be regenerated for this patch. One thing that
> seems to be inconsistent is with the "what gets matched" messages is that
> sometimes it includes extra adornments like curly br
MaskRay updated this revision to Diff 130644.
MaskRay added a comment.
Revert some changes to address comments
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
===
aaron.ballman added a comment.
The documentation needs to be regenerated for this patch. One thing that seems
to be inconsistent is with the "what gets matched" messages is that sometimes
it includes extra adornments like curly braces and other times it does not. It
might be good to pick a styl
MaskRay updated this revision to Diff 130493.
MaskRay added a comment.
More
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
==
MaskRay updated this revision to Diff 130486.
MaskRay added a comment.
More
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
==
lebedev.ri added a comment.
Don't forget that you also need to regenerate the HTML docs:
$ cd docs/tools # yes, cd
$ ./dump_ast_matchers.py
Repository:
rC Clang
https://reviews.llvm.org/D42213
___
cfe-commits mailing list
cfe-commits@lists.l
MaskRay updated this revision to Diff 130458.
MaskRay added a comment.
More
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
=
MaskRay created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
=
19 matches
Mail list logo
