juliehockett abandoned this revision.
juliehockett added a comment.
After some discussion, we decided that the false positive risk for non-kernel
code isn't worth the check.
https://reviews.llvm.org/D41963
___
cfe-commits mailing list
cfe-commits@l
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/CMakeLists.txt:6
FuchsiaTidyModule.cpp
+ ThreadLocalCheck.cpp
OverloadedOperatorCheck.cpp
Please keep this list in alphabetical order.
Comment at: clang-tidy/fuchsia/Thr
juliehockett updated this revision to Diff 129647.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41963
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/ThreadLocalC
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/fuchsia/ThreadLocalCheck.cpp:22
+ // Using thread-local storage is disallowed.
+Finder->addMatcher(varDecl(hasThreadStorageDuration()).bind("decl"), this);
+}
Please run Clang-format over file. Thi
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to the Fuchsia module to warn if thread-local storage is used.
See https://fuc
