Eugene.Zelenko added inline comments.
================ Comment at: clang-tidy/fuchsia/ThreadLocalCheck.cpp:22 + // Using thread-local storage is disallowed. + Finder->addMatcher(varDecl(hasThreadStorageDuration()).bind("decl"), this); +} ---------------- Please run Clang-format over file. This line seems to be formatted incorrectly. ================ Comment at: docs/ReleaseNotes.rst:70 + + Warns if thread-local storage is used. + ---------------- Thread storage duration seems to be [[http://en.cppreference.com/w/cpp/language/storage_duration|proper terminology]]. Same for first sentence in documentation. ================ Comment at: test/clang-tidy/fuchsia-thread-local.cpp:11 + // CHECK-NEXT: extern thread_local int bar; + int baz; + return 0; ---------------- Please separate with empty line. https://reviews.llvm.org/D41963 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits