ilya-biryukov added a comment.
With https://reviews.llvm.org/D41947 in place, do we still need this change? Or
can it be "abandoned" now?
Repository:
rC Clang
https://reviews.llvm.org/D41594
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ilya-biryukov added inline comments.
Comment at: lib/Tooling/Tooling.cpp:287
+ if (Files->getVirtualFileSystem() != VirtualFileSystem) {
+Files = new FileManager(Invocation->getFileSystemOpts(),
VirtualFileSystem);
+ }
vladimir.plyashkun wrote:
> ilya-biry
vladimir.plyashkun added inline comments.
Comment at: lib/Tooling/Tooling.cpp:287
+ if (Files->getVirtualFileSystem() != VirtualFileSystem) {
+Files = new FileManager(Invocation->getFileSystemOpts(),
VirtualFileSystem);
+ }
ilya-biryukov wrote:
> `Files` i
ilya-biryukov added a comment.
I'm not sure if it's ok to ignore the shared `FileManager` here.
@klimek, @bkramer, @alexfh, does tooling library rely on having the same
`FileManager` for all invocations? Is it just a performance optimization or
there's more to it?
Comment at:
vladimir.plyashkun created this revision.
vladimir.plyashkun added reviewers: bkramer, alexfh, ilya-biryukov.
vladimir.plyashkun added a project: clang.
Herald added a subscriber: klimek.
Previously, this argument had no effect, since it didn't proceeded.
For more information, check this review: h
