ilya-biryukov added a comment.
I'm not sure if it's ok to ignore the shared `FileManager` here.
@klimek, @bkramer, @alexfh, does tooling library rely on having the same
`FileManager` for all invocations? Is it just a performance optimization or
there's more to it?
================
Comment at: lib/Tooling/Tooling.cpp:287
+ if (Files->getVirtualFileSystem() != VirtualFileSystem) {
+ Files = new FileManager(Invocation->getFileSystemOpts(),
VirtualFileSystem);
+ }
----------------
`Files` is a raw pointer, so we're leaking memory here.
Repository:
rC Clang
https://reviews.llvm.org/D41594
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
