This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE322097: [clangd] Add more symbol information for code
completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41345?vs=129106&id=129110#toc
Repository:
r
ioeric updated this revision to Diff 129106.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addrress review comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
clangd/
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/index/SymbolYAML.cpp:78
+assert(io.getContext());
+Detail = static_cast(io.getContext())
+ ->Allocate();
this removes the Detail object if it
ioeric added inline comments.
Comment at: clangd/index/Index.h:122
+
+ llvm::Optional Detail;
+
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > ioeric wrote:
> > > > sammccall wrote:
> > > > > I think you probably want a raw pointer rather than optio
ioeric updated this revision to Diff 129075.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang-tools-extra into symbol
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
ioeric updated this revision to Diff 129059.
ioeric marked an inline comment as done.
ioeric added a comment.
- Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
clangd/index/File
ioeric updated this revision to Diff 129058.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- [clangd] Address review comments; made Detail a pointer.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
c
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Just some nits
Comment at: clangd/index/Index.h:122
+
+ llvm::Optional Detail;
+
ioeric wrote:
> sammccall wrote:
> > ioeric wrote:
> > > sammccall wr
ioeric added inline comments.
Comment at: clangd/index/Index.h:122
+
+ llvm::Optional Detail;
+
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > I think you probably want a raw pointer rather than optional:
> > > - reduce the size of the struct when
ioeric updated this revision to Diff 128505.
ioeric added a comment.
- Merge with origin/master. Use Arena for symbol details.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
clangd/index/File
sammccall added inline comments.
Comment at: clangd/index/Index.h:122
+
+ llvm::Optional Detail;
+
ioeric wrote:
> sammccall wrote:
> > I think you probably want a raw pointer rather than optional:
> > - reduce the size of the struct when it's absent
> > - mak
ioeric added inline comments.
Comment at: clangd/index/Index.h:105
+ /// What to insert when completing this symbol (plain text version).
+ std::string CompletionPlainInsertText;
+ /// What to insert when completing this symbol (snippet version).
sammccall wro
ioeric updated this revision to Diff 127781.
ioeric marked an inline comment as done.
ioeric added a comment.
- Merged with origin/master
- Addressed some more comments.
- Add new fields to YAML.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cp
sammccall added inline comments.
Comment at: clangd/index/Index.h:105
+ /// What to insert when completing this symbol (plain text version).
+ std::string CompletionPlainInsertText;
+ /// What to insert when completing this symbol (snippet version).
insert tex
ioeric added a comment.
Thanks for the review!
Logic around CodeCompletionString is pulled into a separate file in
https://reviews.llvm.org/D41450.
I also propagate the new completion info to completion code. I am happy to
split it out if it adds too much noise for the review.
=
ioeric updated this revision to Diff 127730.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Merge with origin/master
- Fixed an error in merge
- Make documentation etc optional in symbols
- Merge remote-tracking branch 'origin/master' into symbol
- Merge branch 'index-completio
sammccall added inline comments.
Comment at: clangd/index/Index.h:92
+ // Documentation including comment for the symbol declaration.
+ std::string Documentation;
AFAIK this information isn't needed for retrieval/scoring, just for display.
LSP has `completio
ioeric created this revision.
ioeric added reviewers: hokein, sammccall.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/index/FileIndex.cpp
clangd/i
18 matches
Mail list logo
