[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

This revision was automatically updated to reflect the committed changes. Closed by commit rC319317: Add the nvidia-cuda-toolkit Debian package path to search path (authored by sylvestre). Repository: rC Clang https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: l

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

jlebar added a comment. I defer to tra on this. https://reviews.llvm.org/D40453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru updated this revision to Diff 124636. https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cuda.cpp +++ lib/Driver/ToolChains/Cu

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:81 + +if (Distro.IsDebian()) + CudaPathCandidates.push_back(D.SysRoot + "/usr/lib/cuda"); No need for a named temporary. `if (Distro(D.getVFS).IsDebian())` should do. Also, please add

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added a comment. On a related note please add context to your patch as described here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface https://reviews.llvm.org/D40453 ___ cfe-commits mailing list cfe-commit

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru updated this revision to Diff 124629. https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cuda.cpp +++ lib/Driver/ToolChains/Cu

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. I'm reluctant to add a distribution-specific search path unconditionally. We do have Distro.IsDebian() https://github.com/llvm-mirror/clang/blob/9f9177d3ef72580ca29e8844327f63d7aa1908af/in

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added a comment. In that case I don't see a way to be "clever", so we have to add the static candidate. I'll let @tra or @jlebar have a final look. https://reviews.llvm.org/D40453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru added a comment. Debian packages don't update the PATH and we are aiming at providing packages working out of the box. In general, yeah, we have to do that for every distros... :/ https://reviews.llvm.org/D40453 ___ cfe-commits mai

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

Hahnfeld added reviewers: tra, jlebar. Hahnfeld added a comment. The change looks good in general and is small enough and last in the candidates list to not break working setups. What concerns me is that we have to do the same for every distribution (I know that Arch Linux for example has CUDA

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru created this revision. Reported here: http://bugs.debian.org/882505 Patch by Andreas Beckmann https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === ---